Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle footnotes that contain footnotes or links #189

Merged
merged 8 commits into from
Aug 26, 2024

Conversation

yshavit
Copy link
Owner

@yshavit yshavit commented Aug 26, 2024

Links can't contain other links or footnotes -- but footnotes can contain either. Add tests and logic to handle it.

Resolves #98.

I found #188 (footnotes that cycle back to themselves) while writing tests for this, but that's a special case, so I'm going to handle it separately.

@yshavit yshavit merged commit 09e5689 into main Aug 26, 2024
4 checks passed
@yshavit yshavit deleted the footnotes-of-footnotes branch August 26, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle case where link text contains a footnote
1 participant